SCRIPTING REVIEW DONE. This is not to say I've checked every single path through the quests, but I've read through the tes3cmd dump and checked that everything makes sense and avoids obvious errors. Some minor stuff could be wrong. See the below KNOWN ISSUES for one thing I'm not really daring to fix yet.
Don't worry about the last-minute code rewrite; I was contemplating doing something similar myself. Improvements are always good.
Please keep in mind that line numbers in code are extremely volatile ;)
The numbering of the uploaded files is messed up, so I'd advise you to number them manually. When you submit a file named
x.esp, the forum looks for the smallest positive integer
n such that
xn.esp is not yet on the list, and renames your file like that. Now that Haplo removed the files TR_q2-19-Imp_6plus_1.esp to TR_q2-19-Imp_6plus_7.esp, the smallest such
n again is 1, and your new file ends up called TR_q2-19-Imp_6plus_1.esp. Anyway it's too late now; I'm just letting you know for your next claim.
I simplified TR_m2_q_19_SjorvanScript.
I've lowered Cajan's fight value to 30 since 50 means "Will attack if they hate you (disposition at 0)" according to UESP. (We must avoid the player killing him before the quest at all costs.) In turn, annoying him now raises his fight value by 8 rather than 5. Likewise for Kiliban.
Replaced "dwemer pipes" by "pipes" in one of the letters. Smugglers shouldn't be that open about these things unless it's really necessary.
In the other letter, capitalized "Dwemer".
One very minor issue:
Code: Select all
if ( dayDelay == 1 )
if ( GameHour >= 6 ) ;The player must watch the meeting until dawn after talking to Erdgolf, after dawn the player must have failed the quest
Set controlQ to 25
endif
elseif ( dayDelay > 1 ) ;If even more time has passed (more than one day) the quest is failed too
Set controlQ to 25
endif
If the player started the quest at (say) 4:59 AM, the timeframe he has for waking up from a 1-hour rest (or, rather, for going to rest, because resting automatically adds 1 hour) is 5:59 AM till 6:00 AM, which is a bit short. I've extended the deadline to 7.
"1 Septims per piece" should be "1 Septim per piece". I don't think the EEC is using golems to do their accounting.
Added "join the East Empire Company" replies for the case the player does not meet the requirements.
The crew of the Reckless Maiden doesn't respond to "discrepancies" at stage 20 (i. e., before talking to Tarus). Changing this breaks some logic (though it doesn't break the quest), so I'm changing the quest instructions to "talk to Tarus first".
Moddisposition results for murder are now heavier (no more -5).
NPCs don't usually say "Telvanni Bug Musk" when it's not the first time they're mentioning it to the player. "Musk" is perfectly enough.
One could speak to Lorus after fighting Kiliban but before getting the musk from Cajan. Lorus would talk as if the player had already retrieved the musk. I've fixed this; you can still get Lorus' old reply if you have 4 bug musk with you.
If you spoke to Melia instead of Lorus in the same situation, you would get into a dialogue loop. Fixed.
If you talked to Erville about the cost estimate (quest Lorus0) without being in the EEC, then the messenger from Solstheim arrived, and then you talked to Lorus about the cost estimate (after joining the EEC), you got (now illogical) "Ah, I see" reply. Fixed.
For some reason, the "Merro Galvix" topic reply
I think I saw an Imperial around town last week. Asking about flin or something. Anyway, he didn't find what he was looking for so he left. No idea where he is now.
was conditioned to quest stage 20, which made it completely useless. Fixed.
Melia's replies in the "two sailors" topic weren't always logical.
Journal TR_m2_eec_lorus1 45: replaced "sailors" by "two sailors" to not suggest attacking the captain.
I rewrote some journal entries of the Lorus1 quest for stylistic reasons. For example:
before:
I fought Kiliban Samarys, and he admitted that he and Cajan had stolen the Telvanni Bug Musk. He claimed that the clerk Tarus Meritorus paid them to do it, although he has no proof. He says Cajan has the Bug Musk.
after:
Once I had loosened his tongue by force, Kiliban Samarys admitted that he and Cajan had stolen the Telvanni Bug Musk. He further claimed that Tarus Meritorus, the clerk at the warehouse, paid them to do it, although he has no proof to offer. Ostensibly, Cajan now has the Bug Musk.
Still this is just a scripting review and I'll have to leave the rest of the dialogue to someone more competent than myself.
KNOWN ISSUES:
Get the Lorus1 quest, talk to Melia but don't talk to Tarus about "discrepancies", kill Cajan, loot his corpse for the musk, then talk to Tarus. He speaks like you have already accused him of stealing the musk, although you haven't. Do we want to fix this? The easiest way is probably to add an "accused" variable to Tarus (or actually use his unused controlQ for that). Do we want that?
If we do so, we could make the sailors confrontable on stage 20 (i. e., before confronting Tarus) as well. This is another thing that makes much sense to add, because why the fuck can't one accuse the sailors before accusing Tarus? Unfortunately this would need some more contingency work, since some greetings and responses by Tarus take it for granted that if one has accused the sailors, one must have accused Tarus as well.
MERGE INSTRUCTION:
ex_de_ship_trapdoor Helnim, Docks (25,0) 207307 7760 150
"This trapdoor shouldn't be locked."
in_c_door_wood_square Helnim, Warehouse 3795 6720 16912
"Should be set to key TR_m2_q_19_EECWarehouseKey."
in_c_door_wood_square Helnim, Warehouse 3661 6464 16912
"Should be set to key TR_m2_q_19_EECWarehouseKey."
in_c_door_wood_square Helnim, Warehouse 3085 6642 16912
"Should be set to key TR_m2_q_19_EECWarehouseKey."
Check that the references to the smuggler crate are still intact (recompile scripts?).
Check that NPCs have been correctly merged and have the correct scripts.
Check that the references to these NPCs are not duplicated.
Check that tr_m2_ao_flingalore journal entries are not duplicated.
Check that "cargo of Flin" reply "Yes, I was assigned the task of locating a ship [...]" correctly ends up between "Suit yourself." and "Do you want to help [...]".